Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create no-invalid-extends.md #101

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Create no-invalid-extends.md #101

merged 1 commit into from
Jul 31, 2023

Conversation

keithamus
Copy link
Collaborator

This adds docs for the no-invalid-extends class recently added in #96.

Refs #82

@43081j
Copy link
Owner

43081j commented Jul 31, 2023

for this and the other PRs can you target ce-next? its mergeable either way but means we can wrap it all up in one branch at the end (major version bump i think)

and if you don't mind, can you add each one to the README? there is a list under Supported Rules (not sure if its up to date though 👀)

thanks so much for sorting these out 🙏

@keithamus keithamus changed the base branch from master to ce-next July 31, 2023 11:57
@keithamus
Copy link
Collaborator Author

and if you don't mind, can you add each one to the README? there is a list under Supported Rules (not sure if its up to date though eyes)

Might be worth doing that after in one hit, as doing them per-PR might cause merge conflicts?

@43081j
Copy link
Owner

43081j commented Jul 31, 2023

good point! lets just do it in a standalone PR

tbh we also need to have a think about what makes sense to be in the recommended and best practice configs then too

@43081j 43081j merged commit ce4505c into 43081j:ce-next Jul 31, 2023
3 checks passed
@keithamus keithamus deleted the patch-3 branch July 31, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants